Adding PSR-17 discovery #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Dec 29, 2018
There was a problem hiding this comment.
this will obsolete the MessageFactoryDiscovery, StreamFactoryDiscovery and UriFactoryDiscovery, right? should we mark those discoveries as deprecated? those will discover httplug factories, while this discovery is for the various factories defined in PSR-17?
i think its great to group them together.
we should probably do a Psr18HttpClientDiscovery too (in a separate pull request)
|
I've added deprecation notices and I've created a new PR for PSR-18 |
dbu
approved these changes
Dec 30, 2018
|
lets wait with merging until we decided naming in #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure someone can ask for PSR17 factory